[v24.x backport] esm: fix source phase identity bug in loadCache eviction#62568
Open
guybedford wants to merge 1 commit intonodejs:v24.x-stagingfrom
Open
[v24.x backport] esm: fix source phase identity bug in loadCache eviction#62568guybedford wants to merge 1 commit intonodejs:v24.x-stagingfrom
guybedford wants to merge 1 commit intonodejs:v24.x-stagingfrom
Conversation
PR-URL: nodejs#62415 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
esm
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #62568 +/- ##
=================================================
- Coverage 90.10% 90.09% -0.02%
=================================================
Files 667 670 +3
Lines 199019 200417 +1398
Branches 38911 39093 +182
=================================================
+ Hits 179335 180565 +1230
- Misses 12040 12177 +137
- Partials 7644 7675 +31
🚀 New features to boost your workflow:
|
Contributor
|
Am I correct that this lands cleanly on the staging branch? If so, let's close this, it's easier to not have to deal with a PR if we can avoid it |
Contributor
Author
|
@aduh95 yes both of these should land cleanly. Do you mean to just use backport-requested label then instead on the originals? I just really want to ensure these don't get missed. |
aduh95
force-pushed
the
v24.x-staging
branch
2 times, most recently
from
24fd6c2 to
c167630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #62415
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com